feat! Create a script to build adaptor package artifacts #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jericht
approved these changes
Feb 11, 2024
epmog
approved these changes
Feb 12, 2024
epmog
reviewed
Feb 12, 2024
src/deadline/houdini_submitter/python/deadline_cloud_for_houdini/submitter.py
Outdated
Show resolved
Hide resolved
mwiebe
force-pushed
the
markw/packaging-artifact
branch
3 times, most recently
from
7c291b0 to
6fa273c
Compare
epmog
force-pushed
the
markw/packaging-artifact
branch
from
6fa273c to
4feeb7f
Compare
epmog
approved these changes
Feb 15, 2024
The breaking change is due to updating the adaptor runtime dependency to 0.4 - Also deprecate the binary name HoudiniAdaptor, and add the name houdini-openjd - Update the adaptor runtime dependency to 0.4, and fix up socket path into server path - Update the submitter to provide both Rez and Conda packages metadata. The Rez package names are the same for now to keep backwards compatibility. - Change the ROP menu from "Digital Assets" to "Farm" matching other render farm ROPs - Adjusted the frame range logic to directly use the hou.Node properties Signed-off-by: Mark Wiebe <[email protected]> Signed-off-by: Morgan Epp <[email protected]>
epmog
force-pushed
the
markw/packaging-artifact
branch
from
4feeb7f to
61bc351
Compare
AWS-Samuel
approved these changes
Feb 15, 2024
src/deadline/houdini_submitter/otls/deadline_cloud.hda/Driver_1deadline__cloud/Tools.shelf
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breaking change is due to updating the adaptor runtime dependency to 0.4
This change corresponds to aws-deadline/deadline-cloud-for-maya#87 and aws-deadline/deadline-cloud-for-nuke#85
What was the problem/requirement? (What/Why)
We have designed a new structure for how we lay out application interface adaptors into packages. In order to simplify the packaging step, we'll put a script that generates an artifact with that layout into each adaptor git repo.
In order to perform the layout we wanted, I needed to modify the adaptor runtime. Those changes are in OpenJobDescription/openjd-adaptor-runtime-for-python#69
The adaptor runtime dependency was out of date, After updating, it required changes from a socket_path to a server_path parameter.
What was the solution? (How)
What is the impact of this change?
The repo has a script that can generate a .tar archive containing a prefix layout of the adaptor python library and its dependencies, along with an entry point.
How was this change tested?
The generated .tar archive was used to create a package, and that was tested on a Deadline Cloud farm with jobs submitted from Houdini.
Was this change documented?
No
Is this a breaking change?
Yes, it updates the openjd adaptor runtime dependency which had a breaking change.